Skip to content

Issue: bundle circuit proving takes too long #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: feat/gpu-0.2.0
Choose a base branch
from
Draft

Issue: bundle circuit proving takes too long #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4113525
add bundle input whose proving takes too long to finish
kunxian-xia May 5, 2025
1f29ae7
add logging
kunxian-xia May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ export RUST_BACKTRACE
RUST_LOG ?= off,scroll_zkvm_integration=debug,scroll_zkvm_verifier=debug,scroll_zkvm_prover=debug,openvm_circuit=debug
export RUST_LOG

export OUTPUT_PATH=metrics.json

ifdef LEGACY
FEATURE := --no-default-features
TESTDATA_PATH := crates/integration/testdata/phase1
Expand Down
2 changes: 1 addition & 1 deletion crates/integration/src/testers/bundle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ impl ProverTester for BundleLocalTaskTester {

fn gen_proving_task() -> eyre::Result<<Self::Prover as ProverType>::ProvingTask> {
Ok(read_json_deep(
Path::new(PATH_TESTDATA).join("bundle-task.json"),
Path::new(PATH_TESTDATA).join("bundle-task-too-long.json"),
)?)
}

Expand Down
1 change: 1 addition & 0 deletions crates/integration/testdata/bundle-task-too-long.json
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 6 additions & 3 deletions crates/integration/tests/bundle_circuit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ use scroll_zkvm_prover::{
task::{bundle::BundleProvingTask, chunk::ChunkProvingTask},
utils::{read_json_deep, write_json},
};
use openvm_stark_sdk::bench::run_with_metric_collection;
use std::str::FromStr;

fn load_recent_batch_proofs() -> eyre::Result<BundleProvingTask> {
Expand Down Expand Up @@ -46,10 +47,12 @@ fn setup_prove_verify() -> eyre::Result<()> {

#[test]
fn setup_prove_verify_local_task() -> eyre::Result<()> {
BundleLocalTaskTester::setup()?;
prove_verify_single_evm::<BundleLocalTaskTester>(None)?;
run_with_metric_collection("OUTPUT_PATH", || {
BundleLocalTaskTester::setup()?;
prove_verify_single_evm::<BundleLocalTaskTester>(None)?;

Ok(())
Ok(())
})
}

#[test]
Expand Down
Loading