Comments support?

[Qtax]

Seems that there is no support for SQL comments, either single line -- comment nor multi-line /* comments */.

Is this something you would accept a PR for?

If so I'd might also improve the tokenization a bit. If you use a single regex you can get rid one of the nested loops and improve performance.

[scriptcoded]

Hey! That's correct, there is no support for comments as of now. If you have a nice solution for adding support for it then please, go ahead! MySQL also supports # comments, so I think there would have to be support for that as well.

I'm on vacation and don't have time to look into how the changes to tokenization might affect the code right now, but please feel free to open a PR for that as well and I'll have a look when I get the time.

And of course, please read the contribution guidelines before you start committing.

Thanks! 😄

[parallels999]

If so I'd might also improve the tokenization a bit. If you use a single regex you can get rid one of the nested loops and improve performance.

It sounds great

[erikn69]

Hi @Qtax , test #139

[Qtax]

@erikn69 hah, I guess we both made a PR for this 😂

I don't think that # is a comment in SQL.

Also I've improved the tokenizer a bit in my PR if you want to have a look.
No nested loops, processes the SQL string just once.

[erikn69]

MySQL also supports # comments, so I think there would have to be support for that as well.

[Qtax]

@erikn69 ah, missed that. Added support for # in my PR.

[scriptsbot]

This issue has been marked as stale because it has been open for 14 days with no activity. Remove the stale label or comment or this will be closed in 5 days.

[scriptcoded]

Closed in #141