We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug The regular expression at https://github.com/scriptcoded/sql-highlight/blob/master/lib/index.js#L42 uses lookbehind, which is currently not supported by latest Safari (https://caniuse.com/js-regexp-lookbehind) and some other browsers; caniuse says that its global support is 76.9%. Safari considers that the code has a syntax error, crashing the page.
To Reproduce
getSegments
(Or just type /((?<![a-zA-z])\d+(?:\.\d+)?)/g on Safari console.)
/((?<![a-zA-z])\d+(?:\.\d+)?)/g
Expected behavior Code should compile.
sql-highlight (please complete the following information): v4.3.1 (latest)
Node.js (please complete the following information): Not applicable.
Browser (please complete the following information): MacOS Safari 16.3 (latest)
The text was updated successfully, but these errors were encountered:
fix: change number regex to not use lookbehind (#106)
8e52120
Successfully merging a pull request may close this issue.
Describe the bug
The regular expression at https://github.com/scriptcoded/sql-highlight/blob/master/lib/index.js#L42 uses lookbehind, which is currently not supported by latest Safari (https://caniuse.com/js-regexp-lookbehind) and some other browsers; caniuse says that its global support is 76.9%. Safari considers that the code has a syntax error, crashing the page.
To Reproduce
getSegments
in your browser bundle.(Or just type
/((?<![a-zA-z])\d+(?:\.\d+)?)/g
on Safari console.)Expected behavior
Code should compile.
sql-highlight (please complete the following information):
v4.3.1 (latest)
Node.js (please complete the following information):
Not applicable.
Browser (please complete the following information):
MacOS Safari 16.3 (latest)
The text was updated successfully, but these errors were encountered: