feat: [UEPR-190] Connecting ToU modal UI to backend #9292
Conversation
| return (<TermsOfUseModalUnder16 | ||
| isOpen={isModalVisible} | ||
| onClose={handleClose} | ||
| onAccept={handleAccept} |
There was a problem hiding this comment.
Why are we not passing showError to TermsOfUseModalUnder16?
|
There is an empty file |
| @@ -19,16 +20,33 @@ export const TermsOfUseLink = chunks => ( | |||
| </a> | |||
| ); | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
nitpick: remove extra line
| @@ -47,13 +65,14 @@ const TermsOfUseModal = ({ | |||
| if (!usesParentEmail || isOver16){ | |||
| return (<TermsOfUseModalOver16 | |||
| isOpen={isModalVisible} | |||
| onClose={handleClose} | |||
| onAccept={handleAccept} | |||
| showErrorMessage={showError} | |||
| />); | |||
| } | |||
|
|
|||
| return (<TermsOfUseModalUnder16 | |||
There was a problem hiding this comment.
Since we're showing the same error message in both cases, what do you think about showing it here, in the parent component?
There was a problem hiding this comment.
It needs to be in the modal itself. I can try changing it so that we have a single Modal element and only modify the content based on the age group. Initially, I took this approach because the modals behaved differently (e.g., showing the close button, being dismissible, etc.), but since we no longer have such functionality, we might as well use a single modal component and only change its contents.
src/lib/session.js
Outdated
| @@ -61,22 +61,7 @@ module.exports.requestSessionWithRetry = (resolve, reject, retriesLeft, totalDel | |||
| ); | |||
| } | |||
| console.log('session body:', body); | |||
Ticket:
UEPR-190
Error UI:
