Skip to content

enable GitHub Actions CI #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Feb 6, 2021

  • remove TravisCI and CircleCI
  • add Github Actions CI

reference: https://github.com/features/actions

@sullis sullis force-pushed the github-actions-ci branch from d85f013 to 463b309 Compare February 6, 2021 18:48
@sullis
Copy link
Contributor Author

sullis commented Mar 6, 2021

ready for review @gslowikowski

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @sullis and sorry this has been sitting here so long. I'll probably just merge this in so we can iterate and improve on this. I'd like to get some of the other prs addressed, but want to make sure CI is in place.

@ckipp01 ckipp01 merged commit 1f42d84 into scoverage:master Nov 16, 2021
@gslowikowski
Copy link
Member

@ckipp01
Copy link
Member

ckipp01 commented Nov 17, 2021

Why did you remove CircleCI configuration? Build failed https://app.circleci.com/pipelines/github/scoverage/scoverage-maven-plugin/2/workflows/337a503a-29f0-4966-b98b-80b8b799682b/jobs/111

Every other project in scoverage is off of CircleCI and all on GitHub actions. Imo it's best to align this, and seeing that it's quite a bit more popular, people will be familiar with it. This repo hasn't seen any action in a while, and I'd like to get some of the prs taken care of, so I'd like to migrate to GitHub actions. I plan on fixing the build with actions to it's ✅, but haven't yet had the time.

Is this something you don't want?

@gslowikowski
Copy link
Member

I'm OK with the change. Disabled CircleCI integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants