Dotty Build Step 1 #1527
Merged
Dotty Build Step 1 #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/cheeseng/scalatest into feature-dotty-build
… needs macro re-implementation.
…eng/scalatest into feature-dotty-build
…n, NormalzingEquality, NormalizingEquivalence, ComposedNormalizingEquality, ComposedNormalizingEquivalence, DefaultEquality and NonEmptyArray to scalacticDotty module.
…RT and // SKIP-DOTTY-END.
…nCheckedConstraint to scalacticDotty.
…izations to scalacticDotty.
…straints, TripleEquals and TypeCheckedTripleEquals to scalacticDotty.
…package for scalacticDotty.
…ing macro expansion.
…ped currently due to blocking issue in dotty.
…Dotty, skipping PropCheckerAsserting for now.
…owing fengyun's advice.
…ed for now as the working nightly Dotty can't compile it yet.
…ch is not allowed in latest dotty build.
…ing 0214 BooleanMacro.scala can't compile anymore.
smarter
reviewed
Feb 20, 2019
| private case class AtMostCollected(num: Int) extends Collected | ||
| private case object NoCollected extends Collected | ||
| private case class ExactlyCollected(num: Int) extends Collected | ||
| // In Dotty when Collected trait is private, object Matchers extends Matchers does not work, hopefully it can be fixed in future version of Dotty before it reaches final. |
There was a problem hiding this comment.
This is a deliberate change and not a bug: if Collected is private, then it should not appear in the signatures of methods and classes with a less restrictive access (like
Otherwise, the privateness of the type cannot be implemented properly: scala/scala3#4154.
There was a problem hiding this comment.
If we agree with the approach in scala/scala3#4154, then we can close scala/scala3#5831
There was a problem hiding this comment.
Yes agree, making it to raise compiler error makes sense even under -language:Scala2 imho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch of changes to support build for Dotty.