-
Notifications
You must be signed in to change notification settings - Fork 13
Add support for multiple volume layers in annotations #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Mostly LGTM, I left a few minor comments, but approving already 👍
Co-authored-by: Jonathan Striebel <[email protected]>
…this; also extend docstring
Co-authored-by: Jonathan Striebel <[email protected]>
Co-authored-by: Jonathan Striebel <[email protected]>
…ng the vcr mark via conftest.py
…ossos-libs into multi-volume-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@jstriebel mypy had some troubles with the |
Weird error, but glad you found an easy fix 👍
Good point! I guess the main problem is, that boltons (from where we import |
Ah, makes sense 👍 I added the cachedproperty stubs, since I consider them relatively important for the type coverage of the annotation module. |
@@ -20,7 +20,7 @@ def main() -> None: | |||
|
|||
# Step 1: Download the dataset and our training data annotation from webKnossos to our local computer | |||
training_data_bbox = wk.BoundingBox.from_tuple6( | |||
annotation.skeleton.user_bounding_boxes[0] | |||
annotation.skeleton.user_bounding_boxes[0] # type: ignore[index] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this. Yesterday, I was unsure how to fix this (strictly speaking one would need to check that user_bounding_boxes
is not None). Ideally, it would always default to an empty list. However, that's likely out-of-scope for this PR. So, let's tackle it at a different point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, cleaning things up a bit more in the skeleton class is definitely a good idea, but let's defer this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and the assertion would clutter the user-facing example to much in my opinion, so i went for the ignore)
Description:
This PR is only fully compatible with webKnossos once scalableminds/webknossos#6028 (comment) is merged, since that PR fixes a naming issue in annotation downloads.
Issues:
Todos:
Make sure to delete unnecessary points or to check all before merging: