Skip to content

Publish dotty-library-bootstrappedJS for sbt-dotty/scripted. #9654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Aug 27, 2020

I tested that locally from a clean .ivy2/local and clean build. But to be sure, is there a way to run the test_sbt workflow for this PR?

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@smarter
Copy link
Member

smarter commented Aug 27, 2020

You'd have to edit the ci config in .github but we can just merge this and see.

@smarter smarter merged commit 757e431 into scala:master Aug 27, 2020
@smarter smarter deleted the fix-sbt-dotty-scripted branch August 27, 2020 14:53
@sjrd sjrd requested a review from anatoliykmetyuk August 27, 2020 14:53
@sjrd sjrd removed the request for review from anatoliykmetyuk August 27, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants