implement readResolve in terms of fromOrdinalDollar method #9612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sjrd
approved these changes
Aug 21, 2020
bishabosha
force-pushed
the
topic/enum-serialization-alt
branch
5 times, most recently
from
5a24a31 to
b81b84c
Compare
|
@nicolasstucki should it be safe to delete |
|
Yes, the |
value cases are collected in EnumCaseCount attachment during nextOrdinal, and an attachment DefinesEnumLookupMethods determines when the final case has been reached, at which point the methods can be generated that depend on the cases.
bishabosha
force-pushed
the
topic/enum-serialization-alt
branch
from
b81b84c to
89d107c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a private
$fromOrdinalmethod to an enum companion that is always generated if there are value enum cases and the enum does not derive fromjava.lang.Enum, for the purposes of replacing a serialized enum case.This means that
EnumValueSerializationProxyis no longer needed, and is moved to the non-bootstrapped library and deleted in the bootstrapped library. The proxy could remain but it makes it more complicated to call$fromOrdinalas the name can be mangled. The fields of the enum constants will be serialised perhaps unnecessarily.This acts as a precursor to only generating
.valueswhen enum declares a pure enumeration:DesugarEnums.nextOrdinalcollects the value enum cases and is aware of when the last case is reached, allowing to make decisions on what methods to generate based on collected constraints.