Remove quoted.Type synthesization #9448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Explicit * Synthesized implicits * Inlined
Just as `$t` is equivalent to `t.T`, `'[T]` is equivalent to `Type[T]`
nicolasstucki
changed the title
Now it is a plain `given` definition and follows the normal implicit resulution rules. Dealiasing of local inconsitent type aliases references are handled by `PCPCheckAndHeal` before healing is atempted.
nicolasstucki
changed the title
liufengyun
approved these changes
Jul 28, 2020
liufengyun
reviewed
Jul 29, 2020
| case NoPrefix if level > levelOf(tp.symbol) && !tp.typeSymbol.hasAnnotation(defn.InternalQuoted_QuoteTypeTagAnnot) => | ||
| tp.dealias match | ||
| case `tp` => tryHeal(tp.symbol, tp, pos) | ||
| case tp1 => apply(tp1) |
There was a problem hiding this comment.
I wasn't clear in the previous comment. I mean what about doing dealiasing at line 175?
There was a problem hiding this comment.
No, that is too much dealiasing. There are a few aliases that we care about, such as the type splices.
I will revert this change.
nicolasstucki
force-pushed
the
move-staging-phase
branch
from
4cda53f to
7c4fa0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scala.quoted.Type.apply[T]. Just as$tis equivalent tot.T,'[T]is equivalent toType[T].quoted.Type