Skip to content

Fix #8869: Make $isInstanceOf$ and $asInstanceOf$ semantic names #9097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #8869: Make $isInstanceOf$ and $asInstanceOf$ semantic names #9097

wants to merge 1 commit into from

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki linked an issue Jun 2, 2020 that may be closed by this pull request
I can call $asInstanceOf$ #8869
Closed
@nicolasstucki nicolasstucki self-assigned this Jun 2, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review June 5, 2020 13:05
@nicolasstucki nicolasstucki removed their assignment Jun 5, 2020
@nicolasstucki nicolasstucki requested a review from odersky June 5, 2020 13:05
@odersky
Copy link
Contributor

odersky commented Jun 8, 2020

I just closed #8897 because I do not think it needs to be fixed. There are lots of other compiler-generated names with $. Singling out isInstanceOf and asInstanceOf is unsystematic.

@odersky odersky closed this Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky Awaiting requested review from odersky

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I can call $asInstanceOf$
2 participants
@nicolasstucki @odersky