Skip to content

fix-#9026 eliminate .. in paths #9027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2020
Merged

Conversation

bishabosha
Copy link
Member

not sure how to ensure we test on 11 in the PR

@bishabosha bishabosha requested a review from smarter May 22, 2020 16:20
@smarter
Copy link
Member

smarter commented May 22, 2020

not sure how to ensure we test on 11 in the PR

You can edit .github/workflows/ci.yaml, but if you tested it manually that should be good enough

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand what changed and why the change was necessary, can you write a more detailed commit message, and add a documentaiton comment above common?

@smarter
Copy link
Member

smarter commented May 22, 2020

Looks like a transient failure in the community build:

2020-05-22T19:45:43.8077306Z curl: (22) The requested URL returned error: 500 Internal Server Error
2020-05-22T19:45:43.8252465Z [error] Test dotty.communitybuild.CommunityBuildTest.sourcecode failed: java.lang.AssertionError:

@anatoliykmetyuk It looks like sourcecode is downloading stuff (mill itself?) in the community build and this isn't cached, that might explain some of the network consumption reported by Fabien if all the mill projects do this.

@felixmulder
Copy link
Contributor

Will first nightly be tonight?

@smarter
Copy link
Member

smarter commented May 24, 2020

@felixmulder
Copy link
Contributor

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants