Fix #7442: Only compute line numbers if the file exists #8883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a partial fix. We just want to avoid the crashes. We will still redesign SourceFile later. |
smarter
approved these changes
May 5, 2020
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 6, 2020
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 6, 2020
Same as scala#8883, but really fixes scala#7442.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 6, 2020
Same as scala#8883, but really fixes scala#7442.
|
This PR seems to have a performance impact on Dotty. |
|
Hmm, I guess this is because we're doing a lot more I/O by always checking if the file exists or not. SourceFile caches the file content so it only does IO once at most normally. Maybe we should check |
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 10, 2020
The exists call introduced in scala#8883 and scala#8897 lead to a slowdown noticeable in benchmarks. Replace them by a check on the content length, since SourceFile caches its content this should avoid any unnecessary IO operation. This required changing the way SourceFile handles empty files to have it return an empty string instead of crashing.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 10, 2020
The exists call introduced in scala#8883 and scala#8897 lead to a slowdown noticeable in benchmarks. Replace them by a check on the content length, since SourceFile caches its content this should avoid any unnecessary IO operation. This required changing the way SourceFile handles empty files to have it return an empty string instead of crashing.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 1, 2020
The exists call introduced in scala#8883 and scala#8897 lead to a slowdown noticeable in benchmarks. Replace them by a check on the content length, since SourceFile caches its content this should avoid any unnecessary IO operation. This required changing the way SourceFile handles empty files to have it return an empty string instead of crashing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.