Skip to content

Fix #831 object self #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2015
Merged

Fix #831 object self #841

merged 2 commits into from
Oct 22, 2015

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 22, 2015

Review by @VladimirNik

@VladimirNik
Copy link
Contributor

@odersky @DarkDimius LGTM

@odersky
Fix scala#831
9421e61 
Need to create a self symbols for modules with explicit self type, but need to take
care it is already typed, or sourceModule risks running into CyclicReferences.
@odersky
Adapt sourceModule to new selfInfo scheme.
b482db8
@odersky odersky force-pushed the fix-#831-object-self branch from f5d88a3 to b482db8 Compare October 22, 2015 11:30
@odersky
Copy link
Contributor Author

odersky commented Oct 22, 2015

Rebased to master

odersky added a commit that referenced this pull request Oct 22, 2015
@odersky
Merge pull request #841 from dotty-staging/fix-#831-object-self
b927f66 
Fix #831 object self
@odersky odersky merged commit b927f66 into scala:master Oct 22, 2015
@allanrenucci allanrenucci deleted the fix-#831-object-self branch December 14, 2017 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @VladimirNik