Skip to content

Fix #8319: Survive bad parameters in compareCaptured #8320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2020
Merged

Fix #8319: Survive bad parameters in compareCaptured #8320

merged 1 commit into from
Feb 17, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Feb 15, 2020

No description provided.

@odersky odersky requested a review from bishabosha February 15, 2020 23:04
@nicolasstucki nicolasstucki mentioned this pull request Feb 17, 2020
Closed
bishabosha
bishabosha approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this on the original code that caused me to open the issue and it solved the problem

@nicolasstucki
Copy link
Contributor

Passed drone CI https://dotty-ci.epfl.ch/lampepfl/dotty/4462

@nicolasstucki nicolasstucki merged commit 7d50725 into scala:master Feb 17, 2020
@nicolasstucki nicolasstucki deleted the fix-#8319 branch February 17, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees

@bishabosha bishabosha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @nicolasstucki @bishabosha