Drop given parameter syntax #8270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
change-given-using-2
branch
from
255f38e to
84a0197
Compare
| @@ -163,8 +163,8 @@ Standard-Section: "ASTs" TopLevelStat* | |||
| POLYtype Length result_Type NamesTypes -- A polymorphic method type `[NamesTypes]result`, used in refinements | |||
| METHODtype Length result_Type NamesTypes -- A method type `(NamesTypes)result`, needed for refinements | |||
| ERASEDMETHODtype Length result_Type NamesTypes -- A method type `erased (NamesTypes)result`, needed for refinements | |||
| GIVENMETHODtype Length result_Type NamesTypes -- A method type `(given NamesTypes)result`, needed for refinements | |||
| ERASEDGIVENMETHODtype Length result_Type NamesTypes -- A method type `given(erased NamesTypes)result`, needed for refinements | |||
| GIVENMETHODtype Length result_Type NamesTypes -- A method type `(using NamesTypes)result`, needed for refinements | |||
There was a problem hiding this comment.
Note: At some point we will need to rename GIVENMETHODtype to CONTEXTMETHODtype
|
Just need to fix the community build. Otherwise LGTM. |
|
@nicolasstucki I've updated the following projects: shapeless effpi is the one that failed because it was unable to find the Serialized/T reference. The changes for all the projects are on the To my knowledge, only xml-interpolator is left to be updated. |
nicolasstucki
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.