-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Port remaining Desugar and Applications errors to the new scheme #8263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
ba5f039
to
75224a5
Compare
ac00dbb
to
e1edca9
Compare
5df66aa
to
bbe845d
Compare
Tried porting couple more error messages from Desugar, and came across a redundant check for extension methods being done in Parsers. I've removed the check from Parsers now as suggested by @smarter here: gitter.im/lampepfl/dotty?at=5e485ace0c50da598c1236e9 |
fb56784
to
24a8ba1
Compare
0893738
to
7a3d106
Compare
All Desugar errors ported to the new scheme now. I've noticed that for some reason, although the checks are successful, this page seems to show that the "continuous-integration/drone/pr" check is still not reported. In fact, the latest build here: https://dotty-ci.epfl.ch/lampepfl/dotty/4482 is successful. |
ebe8850
to
697f6e7
Compare
…rors of the Desugar check to the new scheme
697f6e7
to
6caa732
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ausmarton!
I had to back out most of this. It conflicted in many ways with the preceding PR #8318. @anatoliykmetyuk In the future, let's not merge error message commits in areas that are still in flux, in particular if they have pending PRs. Also, let's forget about error messages tests for these kinds of things. I see no value for these tests, and they cause a huge amount of friction for everyone who has to change things in the future. @ausmarton If you want to try to port to error messages based on the new PR, please go ahead. Please keep in mind to keep things short & simple. I think the advice in #1589 is overblown - following it to the letter slows down our work rather than helping it. |
As described in #1589
Tried porting a couple more of the Errors from Desugar. There are a couple more still remaining, but they seemed to take a bit longer to reproduce the errors for a minimal test case.