Skip to content

Fix #7972: Disallow signatures with _:* return types #7976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2020
Merged

Fix #7972: Disallow signatures with _:* return types #7976

merged 2 commits into from
Jan 15, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Jan 13, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review January 13, 2020 13:36
@nicolasstucki nicolasstucki requested a review from odersky January 13, 2020 13:36
odersky
odersky requested changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not disallow all results with repeated parameters? I think that would be both more consistent and safer. We don't really know what else could go wrong with repeated-parameter results. Theyt were certainly not planned for.

@odersky odersky assigned nicolasstucki and unassigned odersky Jan 13, 2020
@nicolasstucki
Copy link
Contributor Author

I would just have to be careful to now disallow argument bindings with repeated type args.

@nicolasstucki
Copy link
Contributor Author

I made the requested changes.

@odersky odersky merged commit dcf0254 into scala:master Jan 15, 2020
@odersky odersky deleted the fix-#7972 branch January 15, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @odersky