Add error message for only functional erased or implicit types #7848

hope-doe · 2019-12-25T14:39:53Z

No description provided.

anatoliykmetyuk

Otherwise LGTM, the CI failure doesn't seem to be related.

anatoliykmetyuk · 2020-01-07T14:47:19Z

compiler/src/dotty/tools/dotc/parsing/Parsers.scala

@@ -1423,9 +1423,9 @@ object Parsers {
        case FORSOME => syntaxError(ExistentialTypesNoLongerSupported()); t
        case _ =>
          if (imods.isOneOf(GivenOrImplicit) && !t.isInstanceOf[FunctionWithMods])
-            syntaxError("Types with implicit keyword can only be function types `implicit (...) => ...`", implicitKwPos(start))
+            syntaxError(ImplicitTypesCanOnlyBeFunctionTypes())


It's nicer when the error message highlights the keyword in question rather than just points to the location after the erroneous type.

Suggested change

syntaxError(ImplicitTypesCanOnlyBeFunctionTypes())

syntaxError(ImplicitTypesCanOnlyBeFunctionTypes(), implicitKwPos(start))

anatoliykmetyuk · 2020-01-07T14:47:36Z

compiler/src/dotty/tools/dotc/parsing/Parsers.scala

          if (imods.is(Erased) && !t.isInstanceOf[FunctionWithMods])
-            syntaxError("Types with erased keyword can only be function types `erased (...) => ...`", implicitKwPos(start))
+            syntaxError(ErasedTypesCanOnlyBeFunctionTypes())


Suggested change

syntaxError(ErasedTypesCanOnlyBeFunctionTypes())

syntaxError(ErasedTypesCanOnlyBeFunctionTypes(), implicitKwPos(start))

anatoliykmetyuk · 2020-01-07T14:49:07Z

compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala

+  case class ImplicitTypesCanOnlyBeFunctionTypes()(implicit val ctx: Context)
+    extends Message(ImplicitTypesCanOnlyBeFunctionTypesID) {
+    val kind: String = "Syntax"
+    val msg: String = "Types with implicit keyword can only be function types `given (...) => ...`"


Suggested change

val msg: String = "Types with implicit keyword can only be function types `given (...) => ...`"

val msg: String = "Types with given keyword can only be function types `given (...) => ...`"

anatoliykmetyuk · 2020-01-07T14:49:37Z

compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala

+        implicit val ctx: Context = ictx
+        assertMessageCount(1, messages)
+        val ImplicitTypesCanOnlyBeFunctionTypes() :: Nil = messages
+        assertEquals("Types with implicit keyword can only be function types `given (...) => ...`", messages.head.msg)


Suggested change

assertEquals("Types with implicit keyword can only be function types `given (...) => ...`", messages.head.msg)

assertEquals("Types with given keyword can only be function types `given (...) => ...`", messages.head.msg)

anatoliykmetyuk · 2020-01-07T14:53:30Z

Thank you for making the effort to improve the codebase @hope-doe! For us to merge this, could you sign the CLA here?

hope-doe · 2020-01-13T14:03:22Z

@anatoliykmetyuk I've signed the CLA, but still see here "CLA Expected - Waiting for status to be reported " is it okay? or something more needed from my side?
And 'erased' test now fails, since you already saw my test case (and it passed earlier) could you please clarify is it bug or mb my wrong understanding of how it should look

anatoliykmetyuk · 2020-01-14T13:11:42Z

And 'erased' test now fails, since you already saw my test case (and it passed earlier) could you please clarify is it bug or mb my wrong understanding of how it should look

That's because we've recently made the erased an opt-in feature hidden under a flag. Now you need to call the compiler with -Yerased-terms to enable this keyword. Since one of your tests uses it, it now fails.

To run that test with that flag, locate the initializeCtx method here:

https://github.com/lampepfl/dotty/blob/4a514126d87528a6d03364e461d5f409fe714bfe/compiler/test/dotty/tools/DottyTest.scala#L42-L46

And add the following to it:

fc.setSetting(fc.settings.YerasedTerms, true)

To see if your tests pass before submitting them to CI, use from SBT:

testOnly dotty.tools.dotc.reporting.ErrorMessagesTests -- *TypesCanOnlyBeFunctionTypes*

@anatoliykmetyuk I've signed the CLA, but still see here "CLA Expected - Waiting for status to be reported " is it okay? or something more needed from my side?

The status won't update on this PR page. You can check your status here. However, it says false for some reason. Have you signed the Lightbend or Scala CLA? Have you signed it with your GitHub account?

hope-doe · 2020-01-15T14:20:15Z

no idea what problem was with my first attempt, but now sign status is true
thank you for all the help!

anatoliykmetyuk · 2020-01-15T16:01:37Z

LGTM, thanks @hope-doe!

hope-doe mentioned this pull request Dec 25, 2019

Missing error messages #1589

Closed

anatoliykmetyuk self-assigned this Jan 6, 2020

anatoliykmetyuk suggested changes Jan 7, 2020

View reviewed changes

anatoliykmetyuk assigned hope-doe Jan 7, 2020

hope-doe force-pushed the issue-1589-error-mes-implicit-erased-types-can-only-be-ft branch from f6345da to 37dcf9b Compare January 13, 2020 11:32

Add error message for only functional erased or implicit types

c3a72f7

hope-doe force-pushed the issue-1589-error-mes-implicit-erased-types-can-only-be-ft branch from 37dcf9b to c3a72f7 Compare January 15, 2020 13:23

anatoliykmetyuk approved these changes Jan 15, 2020

View reviewed changes

anatoliykmetyuk merged commit c79ffa1 into scala:master Jan 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add error message for only functional erased or implicit types #7848

Add error message for only functional erased or implicit types #7848

hope-doe commented Dec 25, 2019

anatoliykmetyuk left a comment

anatoliykmetyuk Jan 7, 2020

anatoliykmetyuk Jan 7, 2020

anatoliykmetyuk Jan 7, 2020

anatoliykmetyuk Jan 7, 2020

anatoliykmetyuk commented Jan 7, 2020

hope-doe commented Jan 13, 2020 •

edited

Loading

anatoliykmetyuk commented Jan 14, 2020 •

edited

Loading

hope-doe commented Jan 15, 2020

anatoliykmetyuk commented Jan 15, 2020

	syntaxError(ImplicitTypesCanOnlyBeFunctionTypes())
	syntaxError(ImplicitTypesCanOnlyBeFunctionTypes(), implicitKwPos(start))

	syntaxError(ErasedTypesCanOnlyBeFunctionTypes())
	syntaxError(ErasedTypesCanOnlyBeFunctionTypes(), implicitKwPos(start))

	val msg: String = "Types with implicit keyword can only be function types `given (...) => ...`"
	val msg: String = "Types with given keyword can only be function types `given (...) => ...`"

	assertEquals("Types with implicit keyword can only be function types `given (...) => ...`", messages.head.msg)
	assertEquals("Types with given keyword can only be function types `given (...) => ...`", messages.head.msg)

Add error message for only functional erased or implicit types #7848

Add error message for only functional erased or implicit types #7848

Conversation

hope-doe commented Dec 25, 2019

anatoliykmetyuk left a comment

Choose a reason for hiding this comment

anatoliykmetyuk Jan 7, 2020

Choose a reason for hiding this comment

anatoliykmetyuk Jan 7, 2020

Choose a reason for hiding this comment

anatoliykmetyuk Jan 7, 2020

Choose a reason for hiding this comment

anatoliykmetyuk Jan 7, 2020

Choose a reason for hiding this comment

anatoliykmetyuk commented Jan 7, 2020

hope-doe commented Jan 13, 2020 • edited Loading

anatoliykmetyuk commented Jan 14, 2020 • edited Loading

hope-doe commented Jan 15, 2020

anatoliykmetyuk commented Jan 15, 2020

hope-doe commented Jan 13, 2020 •

edited

Loading

anatoliykmetyuk commented Jan 14, 2020 •

edited

Loading