Fix #756 super accessors #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scalac seems to treat superaccessors of traits in a rather peculiar way. They are left unexpanded so that a class implementing several traits with the same superaccessors will get duplicate methods with the same name. It seems this is then resolved in the backend. Here we solve the issue by expanding the names of trait super accessors immediately.
There was a transcription error from scalac which caused the scope of a `!` to be wrong.
Avoid using unexpanded name because it can give wrong results for super accessors of symbolic names. See scala#765. Without this commit t2183.scala crashes the compiler.
| @@ -96,6 +96,7 @@ class tests extends CompilerTest { | |||
|
|
|||
| @Test def new_all = compileFiles(newDir, twice) | |||
|
|
|||
| @Test def neg_abstractOverride() = compileFile(negDir, "abstract-override", xerrors = 2) | |||
There was a problem hiding this comment.
abstract-override.scala is absent in this PR.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix super accessor handling, specifically the problems detected in #756. Review by @DarkDimius, @SethTisue