Runtime benchmarks infrastructure #7596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Nov 21, 2019
bench-run/src/main/scala/Main.scala
Outdated
| } | ||
| } | ||
|
|
||
| def printUsage(): Unit = { |
There was a problem hiding this comment.
Do we need to execute jmh:compile first?
There was a problem hiding this comment.
I don't think it is necessary, at least I didn't do it and it worked. However, it might be necessary to run clean or even rm -rf out because sometimes the incremental compilation has a hard time figuring everything out...
bench-run/src/main/scala/Main.scala
Outdated
|
|
||
| val warmup = if (intArgs.length > 0) intArgs(0).toInt else 20 | ||
| val iterations = if (intArgs.length > 1) intArgs(1).toInt else 20 | ||
| val forks = if (intArgs.length > 2) intArgs(2).toInt else 1 |
There was a problem hiding this comment.
Maybe define a local method:
def getIntArg(i: Int, default: Int): Int =
if (intArgs.length > i) intArgs(i).toInt else default
|
It is weird. I have signed the CLA about one month ago, but it seems like it was reset... I signed it again, so it should be fine now. |
|
The bot is flakey, sometimes it fails to properly execute the check. It is
fine.
…On Mon, 25 Nov 2019, 20:28 brunnerant, ***@***.***> wrote:
It is weird. I have signed the CLA about one month ago, but it seems like
it was reset... I signed it again, so it should be fine now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7596>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA32UHO66KWA6WO6LMXCZI3QVQRMJANCNFSM4JP6RXAQ>
.
|
|
@brunnerant We need a rebase and then we can merge. |
|
Sorry, I forgot to do that earlier. Now it should be ready to merge... |
|
One of the tests failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds the sub-project dotty-bench-run that allows to make runtime benchmarks.
It is uses jmh, as dotty-bench does. There is also support for taking inputs from a file, which is useful because sometimes the inputs cannot be specified by a
@Paramclause.This pull requests also adds a few benchmarks for the tuple related functions, which I have used for my semester project with @nicolasstucki .