Skip to content

[WIP] Port "implicit definition needs explicit type" error to new scheme #7464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

x3ro
Copy link
Contributor

@x3ro x3ro commented Oct 28, 2019

Part of the effort documented in #1589 to port all error messages to
the new scheme.

Marked as WIP because I need some help in coming up with a test case for this part here.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@x3ro
Copy link
Contributor Author

x3ro commented Nov 8, 2019

@nicolasstucki Are you able to suggest someone who could help me figure out the missing test case 🤔

@nicolasstucki
Copy link
Contributor

I can have a look at it. Could you rebase it.

@anatoliykmetyuk
Copy link
Contributor

Thanks for working on this @x3ro!

Marked as WIP because I need some help in coming up with a test case for this part here.

The following two negative tests take that branch:

https://github.com/lampepfl/dotty/blob/4d3f315a6f7804f2a441497e0b2060fba8e5928d/tests/neg/i3067.scala
https://github.com/lampepfl/dotty/blob/4d3f315a6f7804f2a441497e0b2060fba8e5928d/tests/neg/i3067b.scala

So basically make an implicit object extend a type with generic parameters while not fully specifying these generic parameters.

Looks good to me – we can merge it after it is rebased on master and the missing test added.

@anatoliykmetyuk
Copy link
Contributor

I'm closing this one since there was no activity on it for a couple of months – feel free to reopen it if any further progress happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants