Revert "Revert "Upgrade to ASM 7.0"" #7448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5a74718 which itself reverted 0abd076. Since scala#5936 is not fixed yet, so we need to turn off one test in semanticdb which uses parens in a class name. This is problematic, but upgrading to ASM 7.0 still seems worth it since it allows running scalac and dotty in the same classpath which should make it easier to test the scalac tasty reader.
bishabosha
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5a74718 which
itself reverted 0abd076.
Since #5936 is not fixed yet, we need to turn off one test in semanticdb
which uses parens in a class name.