Trait constructors on scala.js #7377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Quiroz <[email protected]>
dottybot
reviewed
Oct 6, 2019
cquiroz
commented
Oct 6, 2019
| @@ -78,6 +78,12 @@ class LinkScala2Impls extends MiniPhase with IdentityDenotTransformer { thisPhas | |||
| val impl = implMethod(sel.symbol) | |||
| if (impl.exists) Apply(ref(impl), This(currentClass) :: args).withSpan(app.span) | |||
| else app // could have been an abstract method in a trait linked to from a super constructor | |||
| case Apply(sel @ Select(Super(a, b), _), args) | |||
There was a problem hiding this comment.
This part should be improved but basically tells to do the transform for constructors even on scala.js
cquiroz
commented
Oct 6, 2019
| if (meth.isConstructor) | ||
| if (meth.isConstructor) { | ||
| if (ctx.settings.scalajs.value) { | ||
| // Is this the static call? | ||
| cls.info.decl(nme.TRAIT_CONSTRUCTOR).symbol |
There was a problem hiding this comment.
I think this is incorrect but haven't been able to figure out the correct call, any suggestions?
cquiroz
commented
Oct 6, 2019
| package hello | ||
|
|
||
| // Minimal reproduction | ||
| object Integral { |
There was a problem hiding this comment.
I'm using this for testing but it probably should be removed before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to get
RangesTeststo run on scala.js but I by default get a Linking errorAfter some discussions in gitter I managed to change it to call the trait constructor but there is an extra step of making the call static and I haven't been able to find it. At the moment my error is as below with a minimal test code to reproduce it
I've discussed this with @sjrd in Gitter but haven't found a solution. Hence I'm sending this draft PR to get feedback