documentation: use more intuitive value to compare against #7134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is also a bug because `Ord`, even though formally not defined here, would normally be expected to have range `-infinity .. +infinity` by an average programmer, not necessarily only taking `-1, 0, 1` as values. Even if it's not a bug, comparing with `0` would look better and more intuitive.
dottybot
reviewed
Aug 29, 2019
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Aug 30, 2019
as suggested in scala#7134 by @vn971
|
Thanks for the fix! I integrated it as part of #6919. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is also a bug because
Ord, even though formally not defined here, would normally be expected to have range-infinity .. +infinityby an average programmer, not necessarily only taking-1, 0, 1as values.Even if it's not a bug, comparing with
0would look better and more intuitive.