Skip to content

Use argument span for inlined singleton an type arguments #6066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 15, 2019
Merged

Use argument span for inlined singleton an type arguments #6066

merged 7 commits into from
Mar 15, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Mar 10, 2019 •
edited
Loading

Fixes #6026 and #6027 by using the span of the inlined argument for the tree of a parameter reference.

@nicolasstucki nicolasstucki self-assigned this Mar 10, 2019
@nicolasstucki nicolasstucki marked this pull request as ready for review March 10, 2019 12:52
@nicolasstucki nicolasstucki removed their assignment Mar 10, 2019
@nicolasstucki nicolasstucki changed the title Fix #6026: Use argument position for inlined singleton arguments Fix #6026: Use argument position for inlined singleton an type arguments Mar 10, 2019
@nicolasstucki nicolasstucki changed the title Fix #6026: Use argument position for inlined singleton an type arguments Fix #6026: Use argument span for inlined singleton an type arguments Mar 10, 2019
@nicolasstucki nicolasstucki changed the title Fix #6026: Use argument span for inlined singleton an type arguments Use argument span for inlined singleton an type arguments Mar 10, 2019
@nicolasstucki nicolasstucki self-assigned this Mar 10, 2019
@nicolasstucki nicolasstucki mentioned this pull request Mar 13, 2019
Open
@nicolasstucki
Disable test and replace it by and equivalent one
649fd92 
Test i4947a.scala has an extra issue (scala#6066) that needs to be fixed
liufengyun
liufengyun approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki mentioned this pull request Mar 15, 2019
Closed
@nicolasstucki nicolasstucki merged commit b5be833 into scala:master Mar 15, 2019
@ghost ghost removed the stat:needs review label Mar 15, 2019
@nicolasstucki nicolasstucki deleted the fix-#6026 branch March 15, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrenucci allanrenucci allanrenucci left review comments

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @liufengyun @allanrenucci