IDE: fix signature help for Java and Scala 2 methods #5927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asking for the signature of a method not defined in sources or in Tasty used to throw an exception because the symbol passed to `defPath` must have a span. The call to `defPath` was only used to determine which parameters were implicit, but this can be done in an easier way by checking `isImplicitMethod`, so we can get rid of it at no loss.
smarter
force-pushed
the
fix/ide-signature-exception
branch
2 times, most recently
from
bc87c99 to
6b01b5d
Compare
It's a hack, but this should be less confusing for students, and it's only temporary until 2.13 is out.
smarter
force-pushed
the
fix/ide-signature-exception
branch
from
6b01b5d to
804c31c
Compare
This is more legitimate than hiding CanBuildFrom since there's never any reason to pass a DummyImplicit instance explicitly, and DummyImplicit is used in the 2.13 standard library to avoid erased signature clashes between overloads.
odersky
approved these changes
Feb 15, 2019
| if (isNewCollections) | ||
| ctx.requiredClass("scala.<:<") | ||
| else | ||
| ScalaPredefModule.requiredClass("<:<") | ||
|
|
||
| def DummyImplicitClass(implicit ctx: Context): ClassSymbol = |
There was a problem hiding this comment.
For my own understanding: Why was this class moved?
There was a problem hiding this comment.
I moved it along with <:< and =:= in scala/scala#7350 to keep Predef as lean as possible, classes can be defined at the top-level so I didn't see why these ones in particular should be nested in Predef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asking for the signature of a method not defined in sources or in Tasty
used to throw an exception because the symbol passed to
defPathmusthave a span. The call to
defPathwas only used to determine whichparameters were implicit, but this can be done in an easier way by
checking
isImplicitMethod, so we can get rid of it at no loss.(note that right now launchIDE is broken, this is being fixed in #5917)