Fix #5145: Improve treatment of soft modifiers #5471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The syntaxHighlighting test fails because it stopped highlighting class inlineThe test should be fixed, but I don't know how to do it. @Duhemm can you help? |
|
I think that @allanrenucci is the Syntax Highlighting Guru |
- Generalize treatment of `inline` to a set of soft modifiers - Make `opaque` a soft modifier - Fix parsing of soft modifiers so that they are treated as modifiers only when preceding a hard modifier or a definition keyword
- also handle parameter modifiers - add a spec
Soft modifiers in modifier position are not considered as binder names.
allanrenucci
force-pushed
the
fix-#5145
branch
from
3200c99 to
36e8fe1
Compare
allanrenucci
approved these changes
Nov 20, 2018
|
I have added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inlineto a set of soft modifiersopaquea soft modifieronly when preceding a hard modifier or a definition keyword