Fix #4375: Properly erase SeqLiteral #4387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the `SeqLiteral#elems` were typed based on the SeqLiteral prototype, which means that nothing ensured that the elems types conformed to the type of `SeqLiteral#elemtpt`. In i4375.scala this means that erasing `SeqLiteral([1, 2], Object)` did not box each element because the expected element type was `WildcardType`. To prevent this sort of issue, we now use the type of SeqLiteral#elemtpt if it exists as the expected type of each element in the sequence.
smarter
force-pushed
the
fix/seqliteral-erasure
branch
from
c5742d5 to
bea7430
Compare
odersky
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the
SeqLiteral#elemswere typed based on theSeqLiteral prototype, which means that nothing ensured that the elems
types conformed to the type of
SeqLiteral#elemtpt. In i4375.scala thismeans that erasing
SeqLiteral([1, 2], Object)did not box each elementbecause the expected element type was
WildcardType.To prevent this sort of issue, we now use the type of SeqLiteral#elemtpt
if it exists as the expected type of each element in the sequence.