Simplify Tasty Trees #4277
Merged
Simplify Tasty Trees #4277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case caused a crash in NamedType, because `Lambda` is higher-kinded. We now report an error instead.
Several changes mean that quite a bit of boilerplate can be removed. Also, some fixes.
odersky
changed the title
odersky
force-pushed
the
simplify-tastytrees
branch
from
5fc60d4 to
55c917d
Compare
nicolasstucki
approved these changes
Apr 9, 2018
tests/pos/TastyADT.scala
Outdated
| } | ||
| object NoSymbol extends Symbol | ||
|
|
||
| trait Definition { |
There was a problem hiding this comment.
Should extend Statement
Avoid `Empty` and `Tpt`
smarter
reviewed
Apr 9, 2018
| case Assign(lhs: Term, rhs: Term) | ||
| case Block(stats: List[Statement], expr: Term) | ||
| case Inlined(call: Term, bindings: List[Definition], expr: Term) | ||
| case Lambda(method: Term, tpt: Term | Empty) | ||
| case Lambda(method: Term, tpt: Option[TypeTree]) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Actually, the doc is wrong. https://github.com/lampepfl/dotty/blob/master/compiler/src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala#L1022-L1025
The docs should be updated to
LAMBDA Length meth_Term target_Type?
There was a problem hiding this comment.
Created #4285 to fix this
smarter
reviewed
Apr 9, 2018
tests/pos/TastyADT.scala
Outdated
| @@ -202,6 +197,8 @@ object tasty { | |||
| object ErasedImplicitMethodType extends SpecializedMethodTypeCompanion | |||
|
|
|||
| case class TypeBounds(loBound: Type, hiBound: Type) | |||
| case class NoPrefix() | |||
| object NoPrefix extends NoPrefix | |||
There was a problem hiding this comment.
Why both a class and an object for NoPrefix?
There was a problem hiding this comment.
To allow NoPrefix to be used in | types and be a singleton at the same time.
nicolasstucki
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several simplifications and fixes for tasty trees.
Also: Avoid crash if prefix of selection is higher-kinded
The test case caused a crash in NamedType, because
Lambdais higher-kinded.We now report an error instead.