Skip to content

Move LiftExprOps to quoted package #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2018
Merged

Move LiftExprOps to quoted package #4135

merged 1 commit into from
Mar 18, 2018

Conversation

nicolasstucki
Copy link
Contributor

To use import scala.quotes._ to import toExpr extension

@nicolasstucki
Move LiftExprOps to quoted package
d3dc9c5 
To use `import scala.quotes._` to import `toExpr` extension
@odersky
Copy link
Contributor

odersky commented Mar 18, 2018

Should it not be in the companion object of Expr? That would correspond to the rule that an implicit conversion from A to B must be co-defined with either A or B. In that case, the conversion is available without needing an import.

@nicolasstucki
Copy link
Contributor Author

This one is just an extension method. The implicit conversion is still in the object Expr.

@odersky
Copy link
Contributor

odersky commented Mar 18, 2018

Ah I misunderstood.

@nicolasstucki nicolasstucki merged commit b750469 into scala:master Mar 18, 2018
@allanrenucci allanrenucci deleted the move-toExpr branch March 18, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

@OlivierBlanvillain OlivierBlanvillain Awaiting requested review from OlivierBlanvillain

Assignees

@OlivierBlanvillain OlivierBlanvillain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @odersky @OlivierBlanvillain