Fix #3916: Fix interpretation of boxed value classes #4025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Feb 21, 2018
| if (clazz.getCanonicalName != tree.symbol.owner.showFullName) value // Already unboxed | ||
| else { | ||
| val method = getMethod(clazz, name, Nil) | ||
| interpreted(method.invoke(value)) |
There was a problem hiding this comment.
A minor irrelevant issue: the name interpreted takes me a little while to realise there's no interpretation.
There was a problem hiding this comment.
I will change the name
| env(qualifier.symbol) | ||
| val value = env(qualifier.symbol) | ||
| val clazz = value.getClass | ||
| if (clazz.getCanonicalName != tree.symbol.owner.showFullName) value // Already unboxed |
There was a problem hiding this comment.
If the value class is a nested inner class, I guess this check will fail.
There was a problem hiding this comment.
I will add a test case and check it
There was a problem hiding this comment.
There is an issue with inner classes but it is not in this code. I will fix it another PR.
liufengyun
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.