-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Restart presentation compilers if memory is low #3967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
language-server/src/dotty/tools/languageserver/Memory.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
package dotty.tools | ||
package languageserver | ||
|
||
object Memory { | ||
|
||
/** Memory is judged to be critical if after a GC the amount of used memory | ||
* divided by total available memory exceeds this threshold. | ||
*/ | ||
val UsedThreshold = 0.9 | ||
|
||
/** If total available memory is unknown, memory is judged to be critical if | ||
* after a GC free memory divided by used memory is under this threshold. | ||
*/ | ||
val FreeThreshold = 0.1 | ||
|
||
/** Turn this flag on to stress test restart capability in compiler. | ||
* It will restart the presentation compiler after every 10 editing actions | ||
*/ | ||
private final val stressTest = false | ||
private var stressTestCounter = 0 | ||
|
||
/** Is memory critically low? */ | ||
def isCritical(): Boolean = { | ||
if (stressTest) { | ||
stressTestCounter += 1 | ||
if (stressTestCounter % 10 == 0) return true | ||
} | ||
val runtime = Runtime.getRuntime | ||
def total = runtime.totalMemory | ||
def maximal = runtime.maxMemory | ||
def free = runtime.freeMemory | ||
def used = total - free | ||
def usedIsCloseToMax = | ||
if (maximal == Long.MaxValue) free.toDouble / used < FreeThreshold | ||
else used.toDouble / maximal > UsedThreshold | ||
usedIsCloseToMax && { runtime.gc(); usedIsCloseToMax } | ||
} | ||
|
||
def stats(): String = { | ||
final val M = 2 << 20 | ||
val runtime = Runtime.getRuntime | ||
def total = runtime.totalMemory / M | ||
def maximal = runtime.maxMemory / M | ||
def free = runtime.freeMemory / M | ||
s"total used memory: $total MB, free: $free MB, maximal available = $maximal MB" | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't
checkMemory()
be called also when doing the other operations? I imagine thatcompletion
andreferences
in particular can require quite some memory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since they do not involve new runs, I don't think it's a problem. The leak comes from the memory of previous runs not being completely reclaimed.