Fix #3012: Avoid swallowing multiple ()'s #3772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow dropping at most one () if a method is called that exists in both ()T and => T forms.
smarter
approved these changes
Jan 7, 2018
| @@ -64,6 +64,7 @@ object Typer { | |||
|
|
|||
| private val ExprOwner = new Property.Key[Symbol] | |||
| private val InsertedApply = new Property.Key[Unit] | |||
| private val DroppedEmptyArgs = new Property.Key[Unit] | |||
There was a problem hiding this comment.
I think every key should have a documentation comment :).
|
|
||
| object a extends fuz.Fuzbar { | ||
| override def str = "" | ||
| str()()()()()() // error: missing argument |
There was a problem hiding this comment.
Add a line with just str()() to check that it's also an error? A pos test with str and str() would be useful too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow dropping at most one () if a method is called that exists
in both ()T and => T forms.