Fix #2858: Handle intersection selection when symbol only exists on one side #2861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix-intersection
branch
2 times, most recently
from
f014a12 to
a784b4a
Compare
smarter
changed the title
|
Also, I think at least one, ad probably both tests on line 431 and 432 are now redundant and should be dropped. |
odersky
requested changes
Jul 13, 2017
| * The aim of these criteria is to give some disambiguation on access which | ||
| * - does not depend on textual order or other arbitrary choices | ||
| * - minimizes raising of doubleDef errors | ||
| */ | ||
| def preferSym(sym1: Symbol, sym2: Symbol) = | ||
| sym1.eq(sym2) || | ||
| (sym1.exists && !sym2.exists) || |
There was a problem hiding this comment.
I think you can just say !sym2.exists. They are different, so sym1.exists is redundant.
smarter
force-pushed
the
fix-intersection
branch
from
a784b4a to
ad1e2e8
Compare
I was able to drop these tests after changing |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.