Skip to content

Fix compilation under Windows #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Conversation

smarter
Copy link
Member

@smarter smarter commented Jun 8, 2017

No description provided.

smarter added 2 commits June 8, 2017 16:40
They have ridiculous default values for max stack size and max heap size.
`createSymbolicLink` documents that it may fail with
UnsupportedOperationException on OS where symbolic links cannot be used,
but it turns out that in practice it fails with FileSystemException on
Windows when you don't have enough privileges to create symbolic links.
@smarter smarter requested a review from liufengyun June 8, 2017 14:42
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@smarter smarter merged commit 0c11376 into scala:master Jun 8, 2017
@allanrenucci allanrenucci deleted the fix-windows branch December 14, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants