Fix the infinite cycle in Lazy Vals #2535
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkDimius
force-pushed
the
topic/lazy-vals-inf-cycle
branch
from
423fe11 to
3cdbd3b
Compare
Reported by Andrzej Plutecki in https://groups.google.com/forum/#!topic/dotty-internals/3LMNItLQw-A I haven't seen this happen in practice in hours and hours of benchmarking, but this is indeed a formal bug.
Long time since I wrote this code. Forgot that `State` doesn't read the state.
nicolasstucki
force-pushed
the
topic/lazy-vals-inf-cycle
branch
from
3cdbd3b to
2f78dac
Compare
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
nicolasstucki
changed the title
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/2535/ to see the changes. Benchmarks is based on merging with master (0eb0423) |
|
Closed in favor of an issue #4189 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #2276