Code

Local optimisations#2513

Code

Merged

DarkDimius merged 88 commits intoscala:masterscala/scala3:masterfrom

dotty-staging:local-opt-rebased-2dotty-staging/dotty:local-opt-rebased-2Copy head branch name to clipboard

May 30, 2017

Commits

Commits on May 29, 2017

• Simplify: initial structure and first optimizations

  DarkDimius

  committed
  098036a

  Copy full SHA for 098036a

• Simplify: add inlineOptions fixes to inlineCaseIntrinsics

  DarkDimius

  committed
  968f478

  Copy full SHA for 968f478

• Simplify: implement constant folding.

  DarkDimius

  committed
  e592460

  Copy full SHA for e592460

• Simplify: do not generate blocks with empty stats.

  DarkDimius

  committed
  fa75463

  Copy full SHA for fa75463

• Simplify: devalify now also performs constant propagation

  DarkDimius

  committed
  fc9c60d

  Copy full SHA for fc9c60d

• Simplify: fix bug in bubbleUpNothing. Definitions should not be skipped.

  DarkDimius

  committed
  ff0a888

  Copy full SHA for ff0a888

• Simplify: improve constant folding & leave breadcrumbs for contributors

  DarkDimius

  committed
  0e6de0a

  Copy full SHA for 0e6de0a

• Add PatternFactorization

  DarkDimius

  committed
  e024e86

  Copy full SHA for e024e86

• Simplify: fix owner corruption when inlining LabelDefs.

  DarkDimius

  committed
  b44e796

  Copy full SHA for b44e796

• Simplify: Start getting rid from Scala2 options and tupples in patterns

  DarkDimius

  committed
  a1c1f7f

  Copy full SHA for a1c1f7f

• Simplify: Don't alias lazy vals

  DarkDimius

  committed
  5974a80

  Copy full SHA for 5974a80

• Simplify: Don't create empty DefDefs if they should do nothing.

  DarkDimius

  committed
  626488a

  Copy full SHA for 626488a

• Simplify: Fix bug with elimination of side-effects.

  DarkDimius

  committed
  f66ac7f

  Copy full SHA for f66ac7f

• Simplify: Don't partials-evaluate case-defs.

  DarkDimius

  committed
  9cdc557

  Copy full SHA for 9cdc557

• Simplify: make object inlining robust against Nothing.

  DarkDimius

  committed
  f521d86

  Copy full SHA for f521d86

• Simplify: Fix several infinite cycles.

  DarkDimius

  committed
  e111da9

  Copy full SHA for e111da9

• Simplify: Don't drop lazy val reads.

  DarkDimius

  committed
  c3f518a

  Copy full SHA for c3f518a

• Simplify: jump jump: optimise label-defs that are themselves forwarders

  DarkDimius

  committed
  315728d

  Copy full SHA for 315728d

• Simplify: start joining ifs if branches are similar.

  DarkDimius

  committed
  a9930f4

  Copy full SHA for a9930f4

• Simplify: String+ isn't symmetric

  DarkDimius

  committed
  e4d36ea

  Copy full SHA for e4d36ea

• Simplify: fix a bug inside isSimilar

  Show description for cc1b78f
  DarkDimius

  committed
  cc1b78f

  Copy full SHA for cc1b78f

• Simplify: don't remove by-name calls

  Show description for 05c2afd
  DarkDimius

  committed
  05c2afd

  Copy full SHA for 05c2afd

• Simplify: don't remove infinite cycles :-)

  DarkDimius

  committed
  9d288e1

  Copy full SHA for 9d288e1

• Got tired of fixing Pattern*Factorization.

  Show description for 5e70a0b
  DarkDimius

  committed
  5e70a0b

  Copy full SHA for 5e70a0b

• simplify: Reading vals through successful casts should be allowed

  DarkDimius

  committed
  d16ad9a

  Copy full SHA for d16ad9a

• simplify: Playing with optimising if expressions.

  Show description for b236b04
  DarkDimius

  committed
  b236b04

  Copy full SHA for b236b04

• simplify: fixes to inlineLocalObjects.

  DarkDimius

  committed
  dc75bd4

  Copy full SHA for dc75bd4

• Simplify: add vilify transformation

  DarkDimius

  committed
  aa854ec

  Copy full SHA for aa854ec

• Simplify: add dropGoodCasts that drops good casts in stat position.

  DarkDimius

  committed
  ae35fb7

  Copy full SHA for ae35fb7

• Simplify: fix the fix of handling by-name arguments.

  DarkDimius

  committed
  646f11a

  Copy full SHA for 646f11a

• Simplify: dropNoEffects now flattens blocks.

  DarkDimius

  committed
  a1ad54c

  Copy full SHA for a1ad54c

• Simplify: inline case-defs that have literal in rhs.

  DarkDimius

  committed
  c6f0e8d

  Copy full SHA for c6f0e8d

• Simplify: Somes\options can be null :-(

  DarkDimius

  committed
  05a5382

  Copy full SHA for 05a5382

• Make optimisation optional.

  DarkDimius

  committed
  e93dd61

  Copy full SHA for e93dd61

• Simplify:inlineLocalObjects: don't inline mutable fields.

  DarkDimius

  committed
  ae9a562

  Copy full SHA for ae9a562

• Simplify: DropGoodCasts: Don't accumulate cast on garbage.

  DarkDimius

  committed
  14bc530

  Copy full SHA for 14bc530

• Simplify: devalify: correctly rebase New when prefix changes.

  DarkDimius

  committed
  a8c9e94

  Copy full SHA for a8c9e94

• Simplify:inlineLocalObjects: make more robust against complex labels.

  DarkDimius

  committed
  6536d8f

  Copy full SHA for 6536d8f

• Simplify: NullCheck: as proposed by @jvican

  DarkDimius

  committed
  2b3d0d2

  Copy full SHA for 2b3d0d2

• Simplify: fix and enable removeUnnecessaryNullChecks.

  DarkDimius

  committed
  8fb9554

  Copy full SHA for 8fb9554

• Add missing NamedType import

  

  jvican

  authored and

  DarkDimius

  committed
  9314e91

  Copy full SHA for 9314e91

• Simplify: devalify: don't kick in on by-name params

  Show description for 02be44b
  

  jvican

  authored and

  DarkDimius

  committed
  02be44b

  Copy full SHA for 02be44b

• Simplify: fix infinite recursion in followCases

  DarkDimius

  committed
  1b6074c

  Copy full SHA for 1b6074c

• Simplify: remove duplicate null tests.

  DarkDimius

  committed
  d25a221

  Copy full SHA for d25a221

• Simplify: this can be dropped inside a block.

  DarkDimius

  committed
  f79f06f

  Copy full SHA for f79f06f

• Finish rebase over dotty upstream

  DarkDimius

  committed
  6cc53c7

  Copy full SHA for 6cc53c7

• Document Simplify optimizations

  Show description for 232761c
  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  232761c

  Copy full SHA for 232761c

• Fix Erasure of uniqueRefDenotations with different underlying type.

  Show description for 76af6c5
  DarkDimius

  committed
  76af6c5

  Copy full SHA for 76af6c5

• Rewrite labelDefs phase

  Show description for aaca2b1
  DarkDimius

  committed
  aaca2b1

  Copy full SHA for aaca2b1

• Soften Ycheck scoping rules for local jumps after LabelDefs

  Show description for b7596ef
  DarkDimius

  committed
  b7596ef

  Copy full SHA for b7596ef

• Fix compilation after rebase

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  a5b688d

  Copy full SHA for a5b688d

• Restore tests moved to disabled

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  4ea9a84

  Copy full SHA for 4ea9a84

• Remove PatternConstantsFactorization & PatternTypeFactorization for now

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  8f470f0

  Copy full SHA for 8f470f0

• Run all tests with -optimise

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  b4af143

  Copy full SHA for b4af143

• Formating / refactoring

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  f775345

  Copy full SHA for f775345

• Remove usage of -optimise in ClassfileParser

  Show description for c42a944
  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  c42a944

  Copy full SHA for c42a944

• Fix a few bugs in Simplify

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  ef2d967

  Copy full SHA for ef2d967

• Expose tpd problem, temporary .toString hack

  Show description for d255b32
  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  d255b32

  Copy full SHA for d255b32

• Work in progress

  Show description for 4763a36
  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  4763a36

  Copy full SHA for 4763a36

• Add missing `.ensureApplied` in `constantFold`

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  2f22230

  Copy full SHA for 2f22230

• bubbleUpNothing: do we want it? It breaks the last 4 failing tests

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  cad5515

  Copy full SHA for cad5515

• Kinda fix toString hack: testPicking w/o -optimise + tpd swtich

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  520e347

  Copy full SHA for 520e347

• Reimplement TypeErasure#erasedLub with the documented algorithm

  Show description for ecaa6e9
  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  ecaa6e9

  Copy full SHA for ecaa6e9

• Clean up Simplify

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  3d4cdd7

  Copy full SHA for 3d4cdd7

• Partially fix pickling tests failing with smarter tpd

  Show description for a2bead9
  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  a2bead9

  Copy full SHA for a2bead9

• Add byte code SimplifyTests

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  dec2766

  Copy full SHA for dec2766

• Refactor the temporary tpd fix

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  a2465b1

  Copy full SHA for a2465b1

• Import Flags._

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  bb0e5b2

  Copy full SHA for bb0e5b2

• Add null check and evalOnce to inlineCaseIntrinsics

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  92ffff7

  Copy full SHA for 92ffff7

• Don't run problematic optimisations AfterErasure

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  0e8cbae

  Copy full SHA for 0e8cbae

• Move to pending t7126.scala (could also be run without -optimise)

  Show description for c516fb3
  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  c516fb3

  Copy full SHA for c516fb3

• Isolate the two failing tests in run-not-optimised

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  123a02d

  Copy full SHA for 123a02d

• Fix ShallowFolder

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  e92c40f

  Copy full SHA for e92c40f

• Do not inline val across class boundaries

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  8a51d32

  Copy full SHA for 8a51d32

• Minor reformatting

  

  OlivierBlanvillain

  authored and

  DarkDimius

  committed
  f564340

  Copy full SHA for f564340

• Add time travelling copies

  Show description for 3cc3121
  

  odersky

  authored and

  DarkDimius

  committed
  3cc3121

  Copy full SHA for 3cc3121

• Simplify: do not drop complex prefixes to case-class apply & unapply.

  Show description for 8a66a25
  DarkDimius

  committed
  8a66a25

  Copy full SHA for 8a66a25

• Simplify: fix build

  DarkDimius

  committed
  65265e6

  Copy full SHA for 65265e6

• tpd: handle closures with less copying + use sameTypes

  DarkDimius

  committed
  7740db5

  Copy full SHA for 7740db5

• Allow redefining tree-copier per phase.

  DarkDimius

  committed
  4d54f3d

  Copy full SHA for 4d54f3d

• Simplify: use a better tree copier.

  DarkDimius

  committed
  ea7a578

  Copy full SHA for ea7a578

• Fix SimplifyTests

  OlivierBlanvillain

  committed
  d09dbd6

  Copy full SHA for d09dbd6

• Simplify: drop more stuff in dropNoEffects.

  DarkDimius

  committed
  8220305

  Copy full SHA for 8220305

• Simplify: run devalify before erasure.

  DarkDimius

  committed
  9c68552

  Copy full SHA for 9c68552

• Refactoring and comments

  OlivierBlanvillain

  committed
  ce50cfe

  Copy full SHA for ce50cfe

Commits on May 30, 2017

• Fix t4859

  OlivierBlanvillain

  committed
  de4dd2c

  Copy full SHA for de4dd2c

• Devalify: also visitType for New nodes

  OlivierBlanvillain

  committed
  fba0d51

  Copy full SHA for fba0d51

• Simpler class hiararchy in SimplifyTests to please JUnit

  OlivierBlanvillain

  committed
  b7149c9

  Copy full SHA for b7149c9