Use ErasedPhantom instead of BoxedUnit as erased unit type. #2449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
May 17, 2017
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Added" instead of "Add")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
nicolasstucki
force-pushed
the
make-unit-erased-phantom
branch
from
9a19c9c to
20acadc
Compare
nicolasstucki
force-pushed
the
make-unit-erased-phantom
branch
from
20acadc to
6e07bcb
Compare
OlivierBlanvillain
approved these changes
May 17, 2017
| } | ||
|
|
||
| public String toString() { | ||
| return "(\uD83D\uDC7B )"; |
There was a problem hiding this comment.
Extra space after 👻?
There was a problem hiding this comment.
The 👻 defines is printed on two characters but the next character is at 1 space of distance. At least on my terminal.
| else { | ||
| assert(sym eq defn.BoxedUnitClass) | ||
| ref(defn.BoxedUnit_UNIT) | ||
| assert(false) // Not in sync with isErasableBottomField |
There was a problem hiding this comment.
assert(false, "Check that isErasableBottomField before calling erasedBottomTree")?
nicolasstucki
force-pushed
the
make-unit-erased-phantom
branch
from
b6c15f8 to
9e71741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.