Add error messages - Parsers.scala:626 and Parsers.scala:1492

[sebastianharko]

Error messages for Parsers.scala:626 and Parsers.scala:1492.

Note: I may have to bump the error message ids - depending on whether the other PR gets merged before this one.

[sebastianharko]

/rebuild

[felixmulder]

So the test that is failing is: ./tests/neg/inlinevals.scala

You can try compiling it with run tests/neg/inlinevals.scala from sbt. I think the issue is that the position has changed from when it was using syntaxError. That method uses in.offset as the pos IIRC

[sebastianharko]

@felixmulder thanks for the hint ! I fixed it :-)

[felixmulder]

@liufengyun has been working on modifiers with positions, and I'm thinking maybe we could enhance this further to say make the following recommendation:

This happens when you accidentally specify the same modifier twice:

private private lazy val x = ...

instead of:

private lazy val x = ...

Where this would be the user's code without the duplicate modifier. What do you think @liufengyun - can this be done with the new modifier objects?

[felixmulder]

No need for .toString in a string interpolation, it gets called automagically :)

[sebastianharko]

/rebuild

[felixmulder]

Hmm, where the CI at?

[felixmulder]

/rebuild

[felixmulder]

Hey @adriaanm and @SethTisue - could you check if something's wrong with the CI? Pretty please :)

edit: thanks guyz, seems to be alive and kicking again

[felixmulder]

/rebuild

[adriaanm]

Looks like you're getting the regular sbt launcher (???) and not xsbt (which I just verified is in /usr/local/bin/sbt on behemoth-2 EDIT: looks like behemoth-1 got out of synch :-().

jenkins@ip-172-31-12-38:/home/ubuntu$ which sbt
/usr/local/bin/sbt
jenkins@ip-172-31-12-38:/home/ubuntu$ sbt -ivy
Aborting: -ivy requires <path> argument

[adriaanm]

There's also a DNS DDOS going on.

[adriaanm]

/rebuild

[adriaanm]

sbt-extras bug should be resolved (scala/scala-jenkins-infra#194)