Ban classes that incompatibly refine type params #14820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain what's the high-level idea? As in, formally state the rules of what is accepted and what is rejected. |
|
Not as of yet. As in, I have something that accepts the right classes and rejects the wrong ones, but I'm not sure how to describe it in words. I'm working on the failures in the real scala 2.13 collections (as opposed to the strawman collection tests I handle already) which might change the test. Ideally in a way which makes the test simpler and therefore easier to describe. |
dwijnand
changed the title
dwijnand
force-pushed
the
checkable-isInstanceOf
branch
from
6e70794 to
ff1441c
Compare
|
@dwijnand it would be good to have a textual description of the changes and to have Martin's yea/nay on it. |
dwijnand
force-pushed
the
checkable-isInstanceOf
branch
2 times, most recently
from
2069f63 to
592f664
Compare
In upickle there was a misuse of Any in a contravariant position.
dwijnand
force-pushed
the
checkable-isInstanceOf
branch
from
592f664 to
f7f634b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where "incompatibly" means outside of sub/supertypes. Intending to resolve #11834. Actually, it's resolving what the "Towards Improved GADT Reasoning in Scala" paper calls "an Old Paradox". (cc @LPTK and @Blaisorblade).
But I had to change the check because invariant refinement only was too strict for some legitimate cases, from the various strawman collection ideas in the test suite. So I came up with another way of checking, which seems to pass all the tests, which compares the combined basetype with the basetype without any parts of the type the involve the middle class.
Sent a draft for some early feedback on how best to do the
baseTypeWithoutpart. Now I need to make use of this ban in GADT reasoning, see the tests I copied into disabled.