Skip to content

Bumb TASTy minor version #13386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Bumb TASTy minor version #13386

merged 2 commits into from
Aug 30, 2021

Conversation

nicolasstucki
Copy link
Contributor

Preparing for 3.1

Closes #13385

Preparing for 3.1

Closes scala#13385
@nicolasstucki nicolasstucki self-assigned this Aug 26, 2021
@bishabosha
Copy link
Member

bishabosha commented Aug 26, 2021

This is failing because the build referenceVersion is a nightly (i.e. with experimental TASTy) - we cant use a nightly compiler to read TASTy produced by another nightly with different MinorVersion

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we can reset the reference version to a non nightly hopefully this would work

@bishabosha bishabosha added this to the 3.1.0 milestone Aug 26, 2021
@nicolasstucki
Copy link
Contributor Author

The first non-nightly version that would work as reference compiler will be 3.1.0-RC1

@bishabosha bishabosha mentioned this pull request Aug 26, 2021
13 tasks
@bishabosha bishabosha marked this pull request as ready for review August 26, 2021 13:46
@bishabosha bishabosha self-requested a review August 26, 2021 13:46
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki
Copy link
Contributor Author

To simplify our own builds, this should be the last PR from https://github.com/lampepfl/dotty/milestone/27 that we merge. Otherwise, we might need to rebuild the full compiler when switching branches.

@smarter
Copy link
Member

smarter commented Aug 28, 2021

This is failing because the build referenceVersion is a nightly (i.e. with experimental TASTy) - we cant use a nightly compiler to read TASTy produced by another nightly with different MinorVersion

But the reference compiler should never be used to read tasty produced by the compiler we compile, so this is likely a bug in the build.

@nicolasstucki
Copy link
Contributor Author

But the reference compiler should never be used to read tasty produced by the compiler we compile, so this is likely a bug in the build.

I did not hit this. I just thought it might happen. If it never reads those tasty it is fine.

@nicolasstucki nicolasstucki merged commit 216b76c into scala:master Aug 30, 2021
@nicolasstucki nicolasstucki deleted the fix-#13385 branch August 30, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump TASTy for 3.1 release
3 participants