-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update scaladoc docs #12787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scaladoc docs #12787
Conversation
https://scala3doc.virtuslab.com/pr-version-browser-docs/scala3/docs/usage/scaladoc/changing-versions.html In case of colourings are wrong check if this action completed OK (it is still running when I'm writing it), but I see they are OK at my local copy |
I am very excited about this feature, especially for the simplicity of having a JSON with URLs. I was experimenting with Docusaurus which also has a similar mechanism relying on making copies of folders. From this doc it is not clear to me how we should treat the JSON document. For example, if I reuse your example:
Does this fille need to be present in both |
Good point, I will elaborate this topic in the docs then. The general idea is that you keep only one JSON file that should be broadly available across the web at given url, let's say |
Thank you for clarifying @BarkingBad! I already see myself writing regexps to change the URL because something changed in my build 😆 This config file could be the beginning of the customization story of sites: fonts, css paths, vcs links etc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for documenting this very useful feature
Currently, the link is embedded into HTML head metadata. It should not be that hard to connect it via the intermediate JSON, though we could make convention out of it, and decide that the Unfortunately I have little time recently (I'm finishing things at the university) so if you'd like to contribute feel free, though I'm not sure that we need all the configuration stuff with css etc., albeit I see your concerns with changing build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I agree with Vinenzo’s suggestions and I have added a couple of other remarks.
Hi, sorry for absence, I was busy with my university exams. I applied your suggested changes. I hope I covered all the problems and we could merge it. |
eb004dd
to
123b286
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @BarkingBad!
Could you take a look @julienrf? I will update docs.scala-lang
New features for Scaladoc
chapter after dotty nightly will be published with the docs so I could point them here.