Skip to content

Remove sbt-dotty #12259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2021
Merged

Remove sbt-dotty #12259

merged 4 commits into from
May 1, 2021

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Apr 28, 2021

  • Remove DottyPlugin
  • Move DottyIDEPlugin to project/, just in case some people are still using it
  • Move the scripted tests to the new sbt-test project

@@ -0,0 +1,34 @@
package sbt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand why this is needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is explained in the comments below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// `extendedClassLoaderCache` is package private in package sbt
val cache = state.extendedClassLoaderCache

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree now that it would be easier if makeScalaInstance is public in sbt...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I missed that, so can we make this method public in sbt? It seems like the only way to properly use ScalaInstance which is public. Otherwise our build could break at any update of sbt.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adpi2 adpi2 force-pushed the remove-sbt-dotty branch from 92d9c5c to 4544542 Compare April 29, 2021 08:33
@adpi2 adpi2 marked this pull request as ready for review April 29, 2021 12:38
@adpi2 adpi2 requested a review from smarter April 29, 2021 12:38
@adpi2 adpi2 merged commit d66a81c into scala:master May 1, 2021
@bishabosha
Copy link
Member

bishabosha commented May 11, 2021

Something broke the classpaths for scala3-bootstrapped in this PR, it now uses the referenceVersion of scala3-library, and not the dottyNonBootstrappedVersion of scala3-library , this prevents us from breaking the tasty version.

When I break the Tasty version, the error I see when trying to run scala3-bootstrapped/scalac is

error while loading Typeable$package$,
class file scala/reflect/Typeable$package.class is broken, reading aborted with class dotty.tools.tasty.UnpickleException
TASTy signature has wrong version.
 expected: {majorVersion: 28, minorVersion: 0}
 found   : {majorVersion: 28, minorVersion: 0 [unstable release: 3]}

This TASTy file was produced by an unstable release.
To read this TASTy file, your tooling must be at the same version.
The TASTy file was produced by Scala 3.0.0-RC3.

So we see it is using the scala3-library_3.0.0-RC3

@adpi2 adpi2 deleted the remove-sbt-dotty branch March 7, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants