Skip to content

Better error message for errors arising from implicit completions #12002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Apr 6, 2021

Fixes #11994

@odersky odersky requested a review from liufengyun April 6, 2021 09:52
@odersky odersky enabled auto-merge April 6, 2021 09:53
We cannot pull the try that catches the type error over both parts of
`tryExtensionOrConversion` since a failed extension should still cause
a conversion to be tried. We need to try both parts separately instead.
@nafg
Copy link

nafg commented Apr 6, 2021

You can add a type via the extension method mechanism?

@odersky
Copy link
Contributor Author

odersky commented Apr 6, 2021

You can add a type via the extension method mechanism?

You can add it with an implicit conversion. The error message is not very specific; it lumps the two together.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit 7ca45d2 into scala:master Apr 6, 2021
@odersky odersky deleted the fix-11994 branch April 6, 2021 18:17
@Kordyjan Kordyjan added this to the 3.0.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error message: Cyclic reference involving method foo
4 participants