Fix #11885: disable flaky idempotency test on Windows #11944
Conversation
| val blacklisted = Set( | ||
| val flakytests = | ||
| if scala.util.Properties.isWin | ||
| then Set(s"pos{JFile.separator}i6507b") |
There was a problem hiding this comment.
| then Set(s"pos{JFile.separator}i6507b") | |
| then Set(s"pos${JFile.separator}i6507b") |
The blacklist bellow seems to have the same issue. Maybe we should handle these paths as JPath to avoid the \ vs / complications.
There was a problem hiding this comment.
Actually, we can try to remove the blacklist below, as they are not effective.
Edit: Changing to JPath will make the code depend on the implementation of JPath toString. I'd suggest keeping what we have.
There was a problem hiding this comment.
I meant not to use the toString in the first place
There was a problem hiding this comment.
This can be improve in a subsequent PR
|
Looks like this didn't work, the merge commit for this PR failed test_windows_full in the usual way: https://github.com/lampepfl/dotty/runs/2229032212 |
|
We forget the file extension, fixed in #11950. |
Fix #11885: disable flaky idempotency test on Windows
This is a temporary fix.
[test_windows_full]