Skip to content

Make community build docs experiment-aware #11935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abgruszecki
Copy link
Contributor

No description provided.

@abgruszecki
Copy link
Contributor Author

Actually tested in #11936.

@abgruszecki
Copy link
Contributor Author

Ok, this seems to work as intended, the parts of the tests that fail are the ones that fail on master as well.

@abgruszecki
Copy link
Contributor Author

@BarkingBad Krzysztof mentioned that you'll be looking at the CI problems with the doctool, correct? Could you ping me when you're done so that I can rebase this PR?

@BarkingBad
Copy link
Contributor

Hey @abgruszecki, I think it was becuase of this nasty bug #11948.

Becuase of that, the useScaladoc.value in dotty/sbt-dotty/sbt-test/sbt-dotty/scaladoc/build.sbt was returning false (becuase version is 3.0.1), hence the aseertion was failing without meaningful comment.

@abgruszecki abgruszecki force-pushed the make-doc-commbuild-aware-of-experiments branch from 0b489f4 to a450551 Compare March 30, 2021 12:05
@BarkingBad
Copy link
Contributor

BarkingBad commented Mar 30, 2021

Oh I didn't see you already fixed that. I think you can rebase now to make the CI pass. You can close my PR or I can resolve the conflict just to add that assertion message for future debugging.

@abgruszecki
Copy link
Contributor Author

@odersky this PR adds support for compilerSupportExperimental in the doc part of the community build. You can see in #11936 that the doctool community build passes if we simulate an experimental-unsupporting build. There is a single compiler test that fails when we do that, but solving that is a separate issue:

9 suites passed, 1 failed, 10 total
    tests/plugins/neg/divideZero-research failed

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit surprised that so many projects require experimental. How did they build before?

I would be good if @nicolasstucki or @liufengyun could review as well.

@odersky odersky assigned liufengyun and nicolasstucki and unassigned odersky Apr 5, 2021
@abgruszecki abgruszecki merged commit 8b35b67 into scala:master Apr 7, 2021
@abgruszecki abgruszecki deleted the make-doc-commbuild-aware-of-experiments branch April 7, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community build documentation test: become experimental-feature-aware
5 participants