-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make community build docs experiment-aware #11935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make community build docs experiment-aware #11935
Conversation
Actually tested in #11936. |
Ok, this seems to work as intended, the parts of the tests that fail are the ones that fail on master as well. |
@BarkingBad Krzysztof mentioned that you'll be looking at the CI problems with the doctool, correct? Could you ping me when you're done so that I can rebase this PR? |
Hey @abgruszecki, I think it was becuase of this nasty bug #11948. Becuase of that, the |
0b489f4
to
a450551
Compare
Oh I didn't see you already fixed that. I think you can rebase now to make the CI pass. You can close my PR or I can resolve the conflict just to add that assertion message for future debugging. |
@odersky this PR adds support for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit surprised that so many projects require experimental. How did they build before?
I would be good if @nicolasstucki or @liufengyun could review as well.
The change was done accidentally.
No description provided.