Skip to content

Merge -explain-types behavior into -explain behavior #11643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 10, 2021

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Mar 7, 2021

Eliminate -explain-types option. Error messages that can show
subtype traces now do so under the -explain mechanism.

Fixes #11637

In fact, it turns out that we need to keep -explain-types since the sbt-tpolecat plugin, which is used in the community build, blows up without it. But it's now essentially an alias of -explain.

odersky added 4 commits March 7, 2021 20:04
Eliminate -explain-types option. Error messages that can show
subtype traces now do so under the -explain mechanism.
@griggt
Copy link
Contributor

griggt commented Mar 7, 2021

The sbt-tpolecat plugin (used by some community build projects) currently enables -explain-types:

https://github.com/DavidGregory084/sbt-tpolecat/blob/b28b564d9c5e9abfddda84be4ed4640d0ccbe383/src/main/scala/io/github/davidgregory084/TpolecatPlugin.scala#L51

Need to keep it for cross compilation.
@odersky
Copy link
Contributor Author

odersky commented Mar 9, 2021

@griggt Can I assign this to you for review? Thanks!

@SethTisue
Copy link
Member

I'd previously suggested on #10737 that this really ought to be a -V option. Not sure if there is opposition to that, or if the question of naming just kind of got forgotten when that PR got closed.

@odersky
Copy link
Contributor Author

odersky commented Mar 9, 2021

@SethTisue So far, there exist no -V options in Scala 3. We should have a look at this later.

Copy link
Contributor

@griggt griggt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@griggt griggt assigned odersky and unassigned griggt Mar 10, 2021
@odersky odersky merged commit 4af1386 into scala:master Mar 10, 2021
@odersky odersky deleted the fix-11637 branch March 10, 2021 21:37
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HKT error report not that clear.
4 participants