Skip to content

Rename scala.runtime.{Tuple => Tuples} #11002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

smarter
Copy link
Member

@smarter smarter commented Jan 5, 2021

To avoid confusion with scala.Tuple. Part of #10602.

/** Filters out those members of the tuple for which the predicate `P` returns `false`.
* A predicate `P[X]` is a type that can be either `true` or `false`. For example:
* ```
* type IsString[x] = x match {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As pointed out here #10896 this example is misleading and won't work without a type bound

type IsString[x] <: Boolean = x match {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing that is independent of this PR.

@smarter smarter force-pushed the rename-runtime-Tuple branch 3 times, most recently from eee615d to aaa6ec1 Compare January 5, 2021 19:59
To avoid confusion with scala.Tuple. Part of scala#10602.
@nicolasstucki
Copy link
Contributor

We should not lose the git history of those sources. We can achieve this the same way I did in #10998.

@smarter smarter force-pushed the rename-runtime-Tuple branch 2 times, most recently from e506915 to aaa6ec1 Compare January 5, 2021 20:54
@smarter
Copy link
Member Author

smarter commented Jan 5, 2021

@nicolasstucki it looks like github rename detection in the changes view doesn't handle multiple copies of the same file, but git does: if I do git log --follow library/src/scala/runtime/Tuples.scala, the full history is displayed, so I don't think there's anything more to do. it's true that if I do git show on the commit it's not displayed as a copy, bu this is fixable by running git config --global diff.renames copies

@nicolasstucki
Copy link
Contributor

We cannot use git log --follow within GitHub, hence I'm not convinced that is a useful workaround.

@nicolasstucki nicolasstucki merged commit 87102a0 into scala:master Jan 6, 2021
@nicolasstucki nicolasstucki deleted the rename-runtime-Tuple branch January 6, 2021 08:16
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants