Remove the -priorityclasspath setting. #10736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lib` is compiled first in this test, in an output directory which has just been cleaned out. Therefore, there is never anything in that directory, and the option has no effect.
It was previously only used in tests, and does not exist in Scala 2.
sjrd
force-pushed
the
remove-priority-classpath-setting
branch
from
b8c6783 to
92c5b82
Compare
smarter
approved these changes
Dec 10, 2020
|
I had marked it as draft. I made it ready for review after I rebased on the fix of the idempotency test. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to be merged before the
Idempotencytest issue is fixed, because this alters precisely that test.Ready for review, however.